fix: bundle classic workers by default (fix #8466)#11874
Open
jonathantneal wants to merge 5 commits intovitejs:mainfrom
Open
fix: bundle classic workers by default (fix #8466)#11874jonathantneal wants to merge 5 commits intovitejs:mainfrom
jonathantneal wants to merge 5 commits intovitejs:mainfrom
Conversation
Member
|
@jonathantneal pushed a commit to fix the syntax error that was causing the CI to fail. result.code = injectEnv + ';' + result.codeThe issue was that that result.code started with a Could you give more context for this PR? Adding a test case that fails without this PR for example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In dev mode, classic workers are not transpiling as they do in build. This causes workers with imports to fail exclusively in development while working successfully in production.
Resolves #8466
P.S. Long time user, first time contributor. I am willing and happy to fix everything wrong with my PR, and I will appreciate any guidance on how to do so.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).