fix: exclude external dependencies from html rewriting#11854
fix: exclude external dependencies from html rewriting#11854leonheess wants to merge 1 commit intovitejs:mainfrom leonheess:main
Conversation
|
@bluwy we have a project with 100+ devs waiting on this fix, is there a way to accelerate this? :) |
|
Waiting on this one to be merged |
|
I've added this to the team board for discussion. I'm unsure if this is the way we want to support externalizing things, because now a build option would affect a non-build flow, and this could indirectly expand to other flows if we don't define a scope. This will also be indirectly covered by #11138 (comment). I've bumped up the priority on this for the next meeting. |
|
In a recent meeting, we decided to go with |
|
@bluwy we have multiple teams waiting on this, can you maybe give some timeline? |
|
Hi, sorry for the wait. We don't usually have timelines for features as the project is community supported. However, I might try to take a stab at this for Vite 5. There's been a couple things I'd like to do and this is one of it. I'll put this on the Vite 5 milestone so we track it. |
|
I tried to implement
And it's also touching a lot of the codebase. At the moment, we're quite behind on the Vite 5 schedule so we'll have to unfortunately tackle this in a minor in the future. Dropping this off the milestone for now. |
|
hi @bluwy, that's not good news. Is there an amount of money that could change that decision? |
|
Thanks for the offer. I won't speak for the other team members, for me I'm limited on bandwidth currently to implement it even with so. With that said, if we manage to slim down the milestone by next week, I could also have time to revisit this. It's also moved out of the milestone for now as it's not a breaking change we have to fit into Vite 5. The new |
|
okay, let me know if we can help. AFAIK we are already sponsoring Vue and Vite to some extent but we would definitely be interested in paying more to resolve this specific issue :) |
|
No accepted solution for years? May be for your current users this is minor, because they already removed external dependencies or wrote workarounds, but for migrating applications with multiple repositories to Vite it's critical. |
|
I guess, checkPublicFile should not check if file exists. Then Missing files are served via proxy option on localhost, and by custom server setup in production (serving assets by one urls, and app by another) |
|
@yyx990803, you are my last hope! we are ready to pay for this 😭😭 |
|
@leonheess yea the scope of this feature goes a bit beyond your code. If you update it to ignore relative paths and to make alias changes and to differentiate SSR and client side, they will probably merge it instantly, but as it is I don't believe they will make a move on this. They will probably make this move when they introduce rolldown to vite which may happen a lot later. I was actually thinking doing this right now bcs I have a project in mind: SSR microfrontend framework but i am still weighing if just creating a plugin is good enough for my usecase |
Description
fixes:
helps with:
Type