Skip to content

fix(types): remove null from CSSModulesOptions.localsConvention#10904

Merged
patak-cat merged 1 commit intovitejs:mainfrom
sapphi-red:fix/remove-null-from-css-modules-localsconvention
Nov 13, 2022
Merged

fix(types): remove null from CSSModulesOptions.localsConvention#10904
patak-cat merged 1 commit intovitejs:mainfrom
sapphi-red:fix/remove-null-from-css-modules-localsconvention

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 13, 2022

Descriptionnone

I expect no one to set null to CSSModulesOptions.localsConvention. But it's technically a breaking change.

refs #10738

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Nov 13, 2022
@patak-cat patak-cat enabled auto-merge (squash) November 13, 2022 07:53
@patak-cat patak-cat merged commit a9978dd into vitejs:main Nov 13, 2022
@sapphi-red sapphi-red deleted the fix/remove-null-from-css-modules-localsconvention branch November 13, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patak-cat patak-cat patak-cat approved these changes

Assignees

No one assigned

Labels

p1-chore Doesn't change code behavior (priority)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sapphi-red @patak-cat