Skip to content

fix(hmr): cannot reload after missing import on server startup (#9534)#10602

Merged
patak-cat merged 1 commit intovitejs:mainfrom
tuchg:fix/missing-import
Oct 25, 2022
Merged

fix(hmr): cannot reload after missing import on server startup (#9534)#10602
patak-cat merged 1 commit intovitejs:mainfrom
tuchg:fix/missing-import

Conversation

@tuchg
Copy link
Contributor

@tuchg tuchg commented Oct 23, 2022 •
edited
Loading

Description

When the devserver is started for the first time, this error will occur if a nested missing import relationship is encountered. For details, please see the playground's missing import test in the commit and the releated issue.

Additional context

close: #9534

the bug comes from pr #8898 . It seems just to be to adjust the logs display effect? Now it seems that some updates cannot be accurately tracked by the updates array, so it follows the previous implementation of versions to send update and execute transform function

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red
Copy link
Member

sapphi-red commented Oct 25, 2022

Thank you for the PR!

I think we should set importerModule.isSelfAccepting = false when an error is thrown in import-analysis plugin.
For example,

vite/packages/vite/src/node/plugins/importAnalysis.ts

Line 297 in df86990

return this.error(

@sapphi-red sapphi-red added feat: hmr p3-minor-bug An edge case that only affects very specific usage (priority) feat: deps optimizer Esbuild Dependencies Optimization labels Oct 25, 2022
@tuchg tuchg force-pushed the fix/missing-import branch from a3e74e3 to ca820f1 Compare October 25, 2022 11:14
@tuchg tuchg force-pushed the fix/missing-import branch from ca820f1 to cac0bb4 Compare October 25, 2022 11:15
@tuchg
Copy link
Contributor Author

tuchg commented Oct 25, 2022 •
edited
Loading

Thank you for the PR!

I think we should set importerModule.isSelfAccepting = false when an error is thrown in import-analysis plugin. For example,

vite/packages/vite/src/node/plugins/importAnalysis.ts

Line 297 in df86990

return this.error(

@sapphi-red yes, u're right. The reason is that isSelfAccepting is missing and lead to stop propagating updates , but I didn't think of this entry. 👍

@patak-cat patak-cat merged commit ee7c28a into vitejs:main Oct 25, 2022
@tuchg tuchg mentioned this pull request Nov 4, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patak-cat patak-cat patak-cat approved these changes

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees

No one assigned

Labels

feat: deps optimizer Esbuild Dependencies Optimization feat: hmr p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Vite 3 regression: missing reload after fixing import error existing on dev server startup

3 participants

@tuchg @sapphi-red @patak-cat