fix: when the file path is an absolute path, parsing causes parameter loss#10449
Merged
patak-cat merged 3 commits intovitejs:mainfrom Oct 25, 2022
Merged
fix: when the file path is an absolute path, parsing causes parameter loss#10449patak-cat merged 3 commits intovitejs:mainfrom
patak-cat merged 3 commits intovitejs:mainfrom
Conversation
Member
|
Would you add a test here? |
Contributor
Author
|
@sapphi-red f7c41be Test added |
sapphi-red
reviewed
Oct 21, 2022
packages/vite/src/node/utils.ts
Outdated
Comment on lines
326
to
328
| if (resolvedUrl.protocol === 'file:') { | ||
| resolvedUrl = pathToFileURL(url) | ||
| } |
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
I agree that this condition should be removed.
Contributor
Author
There was a problem hiding this comment.
@sapphi-red This condition has been removed. 5a42330
7 tasks
Member
|
I confirmed this PR fixes #10278. |
patak-cat
approved these changes
Oct 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10448
When the file path is an absolute path
For example
E:/_yzydeveloper/vite-resolve-url-encode/node_modules/@ui/components/Test.vue?vue&type=template&lang.jsnew URLwill resolve toThe protocol at this time is
e:,causedpathToFileURLprocessing error,cause parameter loss.error handling
normal handling
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).