Closed
Conversation
741f156 to
8bca305
Compare
Member
|
I think it is a good idea to help Qwik users here. I wonder if this could be done through a plugin using Something like |
Contributor
Author
|
ok! let's close it, we will try to solve it using that trick! thanks a lot! if i find some trouble might ping u again :) |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As Qwik maintainer, i would like to disable the default behaviour of Vite that emits .css files, Qwik is a bit special, and this is not a good practice, instead we would like all css imports to behave like inline imports:
ie.
same as:
Occasionally, we find developers forgetting the
?inlineand causing double load of the styles.Additional context
This is an important issue for us, i understand that adding a new option is not ideal, but i think it's a valid use case.
Also, i understand the naming, or location of the config might not be correct, i am open to any different API as long as we can change the default behaviour!
As soon as some vite core team confirms this can get merged, i can work on adding new unit tests!!
Thanks so much for the amazing work!
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).