HMR client port should default to 443 on https #5153
Description
Describe the bug
Related to #3737
- Https strongly implies a reverse proxy is being used.
- getting an Https certificate outside of port 443 is quite difficult
- this would work with all the biggest cloud dev platforms like Codesanbox, Glitch and Runkit and not interfere with any local devs that I can think of.
I've given this some thought after trying to guess which port I should specify for HMR. And writing some nasty code to accomplish that.
Next Step: someone should make a PR... I might do it if I figure out how the HMR config is handled. Vite is the middleman here so, handling in Vite would be the fastest way to fix it. It might be fixable at the HMR client level, but as sure that development environment is as much of their concern as it is vite's.
DNS: more projects will need to implement hacky PR's like the one written by this dude https://github.com/marshallswain/feathers-pinia/pull/5/files
Reproduction
https://githubbox.com/marshallswain/feathers-pinia
System Info
Codesanbox (Official Node.js debian container)Used Package Manager
yarn
Logs
// https://vitejs.dev/config/
export default defineConfig({
plugins: [vue()],
server: {
hmr: {
port: parseInt(process.env.KUBERNETES_SERVICE_PORT, 10) || 3000
}
},
### Validations
- [X] Follow our [Code of Conduct](https://github.com/vitejs/vite/blob/main/CODE_OF_CONDUCT.md)
- [X] Read the [Contributing Guidelines](https://github.com/vitejs/vite/blob/main/CONTRIBUTING.md).
- [X] Read the [docs](https://vitejs.dev/guide).
- [X] Check that there isn't [already an issue](https://github.com/vitejs/vite/issues) that reports the same bug to avoid creating a duplicate.
- [X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
- [X] Check that this is a concrete bug. For Q&A open a [GitHub Discussion](https://github.com/vitejs/vite/discussions) or join our [Discord Chat Server](https://chat.vitejs.dev/).
- [X] The provided reproduction is a [minimal reproducible example](https://stackoverflow.com/help/minimal-reproducible-example) of the bug.