Skip to content
This repository was archived by the owner on Mar 19, 2026. It is now read-only.

fix: resolve default export consistently#444

Merged
sapphi-red merged 3 commits intorolldown-vitefrom
fix/resolve-default-export-consistently
Oct 20, 2025
Merged

fix: resolve default export consistently#444
sapphi-red merged 3 commits intorolldown-vitefrom
fix/resolve-default-export-consistently

Conversation

@sapphi-red
Copy link
Copy Markdown
Member

@sapphi-red sapphi-red commented Oct 7, 2025

Description

requires rolldown/rolldown#6434
fixes #425
fixes #421 (fixes the inconsistency, the expected error happens)

  • fix & add unit tests
  • investigate playground/css-codesplit-cjs/__tests__/css-codesplit-cjs.spec.ts failure: previously it happened to not include require in the output file, but now it includes it. so this is not a bug
  • run ecosystem-ci

@sapphi-red sapphi-red marked this pull request as draft October 7, 2025 11:06
@sapphi-red sapphi-red force-pushed the fix/resolve-default-export-consistently branch 2 times, most recently from dbebcbf to 2715652 Compare October 16, 2025 12:00
@sapphi-red
Copy link
Copy Markdown
Member Author

https://github.com/vitejs/vite-ecosystem-ci/actions/runs/18560597259

@sapphi-red sapphi-red force-pushed the fix/resolve-default-export-consistently branch 3 times, most recently from d644c9b to a72c3b8 Compare October 20, 2025 07:35
@sapphi-red sapphi-red force-pushed the fix/resolve-default-export-consistently branch from a72c3b8 to 633a633 Compare October 20, 2025 07:37
@sapphi-red sapphi-red marked this pull request as ready for review October 20, 2025 07:48
@sapphi-red sapphi-red merged commit 46e89c0 into rolldown-vite Oct 20, 2025
27 of 28 checks passed
@sapphi-red sapphi-red deleted the fix/resolve-default-export-consistently branch October 20, 2025 07:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

1 participant