Skip to content

fix(core): auto-close dock overflow panel when dock minimizes#338

Merged
antfu merged 1 commit into
vitejs:mainfrom
JianJroh:fix/dock-overflow-panel-minimize-sync
May 14, 2026
Merged

fix(core): auto-close dock overflow panel when dock minimizes#338
antfu merged 1 commit into
vitejs:mainfrom
JianJroh:fix/dock-overflow-panel-minimize-sync

Conversation

@JianJroh

Copy link
Copy Markdown
Contributor

Description

Fixes an orphan UI state where the dock collapses into a single icon (after inactiveTimeout of mouse inactivity) but the open overflow panel keeps floating in its original location.

Before

2026-05-12.140551.mp4

After

2026-05-12.140437.mp4

Changes

  • Dock.vue watches isMinimized; when it flips to true, the overflow panel is dismissed via setDocksOverflowPanel(null)
  • DockOverflowButton.vue emits a new activity event from mousemove on the panel content, which Dock.vue wires to bringUp — so cursor movement inside the panel counts as activity and keeps the dock awake (otherwise the panel would self-close after 3s even while the user is picking an entry, since the panel lives outside the dock DOM subtree)

@netlify

netlify Bot commented May 12, 2026

Copy link
Copy Markdown

Deploy Preview for devfra canceled.

Name Link
🔨 Latest commit 34972ae
🔍 Latest deploy log https://app.netlify.com/projects/devfra/deploys/6a02c6ee2fc5890008926651

@pkg-pr-new

pkg-pr-new Bot commented May 12, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@vitejs/devtools@338
npm i https://pkg.pr.new/@vitejs/devtools-kit@338
npm i https://pkg.pr.new/@vitejs/devtools-rolldown@338
npm i https://pkg.pr.new/@vitejs/devtools-self-inspect@338

commit: 54404e9

@JianJroh JianJroh force-pushed the fix/dock-overflow-panel-minimize-sync branch from 34972ae to 54404e9 Compare May 13, 2026 02:52
@antfu antfu merged commit 897ce82 into vitejs:main May 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants