Skip to content

docs(errors): rework error pages with linked sources, drop migration framing#318

Merged
antfu merged 3 commits into
mainfrom
antfu/sacramento
May 8, 2026
Merged

docs(errors): rework error pages with linked sources, drop migration framing#318
antfu merged 3 commits into
mainfrom
antfu/sacramento

Conversation

@antfu

@antfu antfu commented May 8, 2026

Copy link
Copy Markdown
Member

Description

Rework all error reference pages (docs/errors/, devframe/docs/errors/) so the ## Source section is genuinely useful: bullet list of GitHub-linked files (call site + diagnostics definition) with a one-line role per entry, instead of a single un-clickable backtick path. The redundant > Package: callout is dropped from every page (and from the index tables).

20 stale DTK pages whose runtime emission has moved to devframe (DTK0001-7, 9, 15-22, 24-27) are deleted — they were duplicating the corresponding DF pages — and the DTK sidebar generator is shrunk to an explicit list of the 12 surviving codes.

All "Migrated from DTK" framing is removed: top callouts on DF0021-28, ## Migrated from sections on DF0001-13, the DF index column, and the comments in devframe/.../rpc/diagnostics.ts and node/diagnostics.ts. The AGENTS.md / CLAUDE.md "Adding a new error" template is updated to match the new format.

Linked Issues

Additional context

Net: 170 insertions / 1579 deletions across 72 files. Verified pnpm lint clean and git grep confirms zero residual Migrated from DTK or > Package: hits.

🤖 Generated with Claude Code

antfu and others added 2 commits May 8, 2026 11:16
…framing

- Replace single-path `## Source` with bullet lists of GitHub-linked files plus per-file role descriptions (call site + diagnostics file).
- Drop the redundant `> Package:` callout from every error page and the matching column from `docs/errors/index.md`.
- Delete 20 stale DTK pages whose code now lives in devframe under DF codes (DTK0001-7, 9, 15-22, 24-27); shrink the DTK sidebar generator to an explicit list of the 12 surviving codes.
- Remove all "Migrated from DTK" framing — top callouts on DF0021-28, `## Migrated from` sections on DF0001-13, the DF index column, and the comments in `devframe/.../rpc/diagnostics.ts` + `node/diagnostics.ts`.
- Refresh the CLAUDE.md / AGENTS.md "Adding a new error" template to match the new format.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The `defines <CODE>` line pointing at `diagnostics.ts` added no information
on top of the call-site bullet. Source now lists only the file(s) where the
code is actually emitted, with multiple bullets reserved for codes that are
genuinely thrown from more than one place (only DF0024 today).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@pkg-pr-new

pkg-pr-new Bot commented May 8, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@vitejs/devtools@318
npm i https://pkg.pr.new/@vitejs/devtools-kit@318
npm i https://pkg.pr.new/@vitejs/devtools-rolldown@318
npm i https://pkg.pr.new/@vitejs/devtools-self-inspect@318

commit: bfc6c8c

@antfu antfu merged commit 9ab8ef1 into main May 8, 2026
9 checks passed
@antfu antfu deleted the antfu/sacramento branch May 8, 2026 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant