fix(vite): gracefully handle missing package manifest (#151)

Gianthard-cyh · web-flow · commit 78243a92f30a · 2026-01-07T15:53:12.000+09:00
diff --git a/packages/vite/src/app/components/packages/Table.vue b/packages/vite/src/app/components/packages/Table.vue
@@ -2,7 +2,7 @@
 import type { PackageInfo, SessionContext } from '~~/shared/types'
 import { useRoute } from '#app/composables/router'
 import { useCycleList } from '@vueuse/core'
-import { Menu as VMenu } from 'floating-vue'
+import { Tooltip, Menu as VMenu } from 'floating-vue'
 import { settings } from '~~/app/state/settings'
 
 withDefaults(defineProps<{
@@ -69,9 +69,23 @@ function toggleSizeSortType() {
           :class="[index === packages.length - 1 ? 'border-b-0' : '']"
           :to="{ path: route.path, query: { package: `${item.name}@${item.version}` } }"
         >
-          <div v-if="!groupView" role="cell" font-mono flex-none min-w80 py1.5 px2 ws-nowrap text-sm>
-            <DisplayHighlightedPackageName :name="item.name" />
-          </div>
+          <Tooltip
+            :triggers="['hover']"
+            :delay="1200"
+            :disabled="item.name.length < 30"
+          >
+            <div
+              v-if="!groupView" role="cell" font-mono flex-none w80 py1.5 px2 ws-nowrap text-sm overflow-hidden
+              truncate
+            >
+              <DisplayHighlightedPackageName :name="item.name" />
+            </div>
+            <template #popper>
+              <span font-mono text-sm>
+                {{ item.name }}
+              </span>
+            </template>
+          </Tooltip>
           <div role="cell" flex="~ items-center" text-left flex-none font-mono py1.5 px2 text-sm min-w40 op80 :class="{ 'text-primary': item.duplicated }">
             {{ item.version }}
           </div>
diff --git a/packages/vite/src/node/rpc/functions/rolldown-get-packages.ts b/packages/vite/src/node/rpc/functions/rolldown-get-packages.ts
@@ -42,8 +42,21 @@ export async function getPackagesManifest(reader: RolldownEventsReader) {
     }
   })
   await Promise.all(packages.map(async (p) => {
-    const manifest = await readProjectManifestOnly(p.dir)
-    const packageKey = `${manifest.name!}@${manifest.version!}`
+    let packageKey = ''
+    let manifest = null
+
+    try {
+      manifest = await readProjectManifestOnly(p.dir)
+      packageKey = `${manifest.name!}@${manifest.version!}`
+    }
+    catch (err: any) {
+      if (err?.code === 'ERR_PNPM_NO_IMPORTER_MANIFEST_FOUND') {
+        packageKey = `${p.dir}`
+      }
+      else {
+        throw err
+      }
+    }
     const packageInfo = packagesManifest.get(packageKey)
     const importers = getImporters(p.path, p.dir).map(i => ({ path: i, version: '' }))
     if (packageInfo) {
@@ -59,8 +72,8 @@ export async function getPackagesManifest(reader: RolldownEventsReader) {
     }
     else {
       packagesManifest.set(packageKey, {
-        name: manifest.name!,
-        version: manifest.version!,
+        name: manifest?.name || p.dir,
+        version: manifest?.version || '(unknown)',
         dir: p.dir,
         files: [{
           path: p.path,
@@ -101,7 +114,17 @@ export const rolldownGetPackages = defineRpcFunction({
               if (duplicated) {
                 files = await Promise.all(files.map(async (f) => {
                   const importers = await Promise.all(f.importers.map(async (i) => {
-                    const manifest = isNodeModulePath(i.path) ? await readProjectManifestOnly(getPackageDirPath(i.path)) : null
+                    let manifest = null
+                    try {
+                      if (isNodeModulePath(i.path)) {
+                        manifest = await readProjectManifestOnly(getPackageDirPath(i.path))
+                      }
+                    }
+                    catch (err: any) {
+                      if (err?.code !== 'ERR_PNPM_NO_IMPORTER_MANIFEST_FOUND') {
+                        throw err
+                      }
+                    }
                     return { ...i, version: manifest?.version ?? '' }
                   }))
                   return { ...f, importers }
