Skip to content

handle reports w/o columns info. "timesheets" for me doesn't.#192

Closed
dtzWill wants to merge 1 commit intovit-project:2.xfrom
dtzWill:handle-reports-without-columns-info
Closed

handle reports w/o columns info. "timesheets" for me doesn't.#192
dtzWill wants to merge 1 commit intovit-project:2.xfrom
dtzWill:handle-reports-without-columns-info

Conversation

@dtzWill
Copy link
Copy Markdown

@dtzWill dtzWill commented Aug 3, 2019

Might only be needed with latest taskwarrior 2.5.2, not sure, and wasn't sure if this was best way to handle it.

If nothing else, heads-up in case you encounter this down the road! :)

Thanks for all your work, BTW! I think the revived vit might be a key player in my return to taskwarrior goodness!

@thehunmonkgroup
Copy link
Copy Markdown
Member

I'm not quite clear how a report can't have any columns, what's the name of the report you're trying to view? Is this a custom report?

@thehunmonkgroup thehunmonkgroup added this to the v2.0 milestone Aug 6, 2019
@thehunmonkgroup thehunmonkgroup modified the milestones: v2.0, v2.x Sep 28, 2019
@thehunmonkgroup
Copy link
Copy Markdown
Member

OK, I got 2.5.2 installed to test this myself. As reported, the timesheet report has no columns:

task _show | grep report.timesheet
report.timesheet.filter=(+PENDING and start.after:now-4wks) or (+COMPLETED and end.after:now-4wks)

However, I'm unclear if this is a bug in the development version of TaskWarrior, or some new kind of approach to a report that allows zero columns. I can't really fix this issue until I confirm with the TaskWarrior maintainer what's going on there.

@dtzWill
Copy link
Copy Markdown
Author

dtzWill commented Oct 1, 2019

Thank you for investigating! Sorry for not responding sooner, apparently missed your message? :(

I'm also unsure how to best handle this, but FWIW it does appear to be limited to the timesheet "report". Even so, waiting until there's a clearer picture of things sounds like the way to go. In the meantime perhaps the PR will help lost taskwarrior users ("taskwarriors"? 😁) encountering this also. Thanks again.

@thehunmonkgroup
Copy link
Copy Markdown
Member

After talking with the TaskWarrior maintainers, I decided to take a different approach to fix this issue.

See the commit message in bf4cb06 for a full explanation.

@dtzWill
Copy link
Copy Markdown
Author

dtzWill commented Oct 3, 2019 via email

@shaicoleman
Copy link
Copy Markdown

shaicoleman commented Jun 18, 2020

Can a new version be published to fix this?

@thehunmonkgroup
Copy link
Copy Markdown
Member

Doesn't warrant a point release, as the fix addresses features in an unreleased version of TaskWarrior.

You're welcome to run a development version of VIT should you wish to have access to the fix.

@YAMLcase
Copy link
Copy Markdown

YAMLcase commented Dec 19, 2020

taskwarrior 2.5.2 has now been released and the bug persists

@thehunmonkgroup
Copy link
Copy Markdown
Member

@YAMLcase the bug was fixed in bf4cb06

VIT will probably get a point release in the near future, until then you can run the development version, which is compatible with TaskWarrior 2.5.2: https://github.com/vit-project/vit/blob/2.x/DEVELOPMENT.md

@YAMLcase
Copy link
Copy Markdown

YAMLcase commented Dec 19, 2020

Thank you. I can confirm the 2.X branch has the fix and runs fine under python 3.8 on Ubuntu 20.08.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants