Skip to content

param with slash  #187

@daddybh

Description

@daddybh

Hi, I encountered an issue in my search page.

I have router like : /search/:keyword/, when keyword including a slash, eg: /seach/markdown%20%2F%20wiki, the regexp will match the item before slash.

I find there is a decodeURIComponent call at
https://github.com/visionmedia/page.js/blob/master/page.js#L437.

What's the concern to decode the url when doing match? Can we just remove it? :D

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions