Support src_mac, dst_mac and vlan id in flower filters#809
Closed
shuowang-123 wants to merge 2 commits intovishvananda:mainfrom
Closed
Support src_mac, dst_mac and vlan id in flower filters#809shuowang-123 wants to merge 2 commits intovishvananda:mainfrom
shuowang-123 wants to merge 2 commits intovishvananda:mainfrom
Conversation
Author
|
This should address second request from #589 |
Collaborator
Owner
|
Closing due to inactivity. Feel free to reopen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See title, so users are able to filter flower rules based on src/dst mac address. I ran the test on an Oracle Linux 8 virtual machine and it passed:
[] go test -run "TestFilterFlowerAddDel"
PASS
ok github.com/vishvananda/netlink 0.017s
I also ran the test (without cleanup) on the same machine, was able to see the flower rule was created correctly, as reported by "tc":
[] ip netns exec netns1 tc filter show dev foo ingress
filter parent ffff: protocol all pref 1 flower chain 0
filter parent ffff: protocol all pref 1 flower chain 0 handle 0x1
dst_mac 2c:54:91:88:c9:e5
src_mac 2c:54:91:88:c9:e3
eth_type ipv4
dst_ip 1.0.0.1/24
src_ip 2.0.0.1/24
enc_dst_ip 3.0.0.1/24
enc_src_ip 4.0.0.1/24
enc_key_id 1234
enc_dst_port 8472
not_in_hw
action order 1: mirred (Egress Redirect to device bar) stolen
index 1 ref 1 bind 1