filter: Add support for the csum action in u32#718
Merged
aboch merged 1 commit intovishvananda:mainfrom Mar 29, 2022
Merged
Conversation
This patch adds support for the U32 action that can force a csum recalculation in different layers of a packet.
Contributor
Author
|
@vishvananda (or someone else with perms to merge), is there something extra I'm missing to get this looked at? |
Owner
|
This lgtm. I'll give @aboch a chance to comment on it before i merge |
Contributor
Author
|
@aboch any comments on this, or can @vishvananda merge? |
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds support for the U32 action that can force a csum
recalculation in different layers of a packet. It closes #668
I wrote a small test program to match the behaviour of the equivalent
tcinvocation:This does the same as
tc filter add dev dummy0 egress pref 200 u32 match ip6 protocol 6 0xff action csum tcp udp continue, which can be seen with a show: