Skip to content

add support for bareudp link type#657

Merged
aboch merged 1 commit intovishvananda:masterfrom
bersoare:bareudp
Sep 17, 2021
Merged

add support for bareudp link type#657
aboch merged 1 commit intovishvananda:masterfrom
bersoare:bareudp

Conversation

@bersoare
Copy link
Copy Markdown
Contributor

@bersoare bersoare commented Jun 3, 2021

this PR adds support for bareudp link attributes.

2 links with similar attributes - one created using this code, another one using iproute2:

13: bareudp1: <POINTOPOINT,MULTICAST,NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
    link/none  promiscuity 0 minmtu 68 maxmtu 65527
    bareudp dstport 6636 ethertype mpls_uc srcportmin 12345 multiproto addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
14: foo99: <POINTOPOINT,MULTICAST,NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default
    link/none  promiscuity 0 minmtu 68 maxmtu 65527
    bareudp dstport 6635 ethertype mpls_uc srcportmin 12345 multiproto addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535

aboch
aboch reviewed Jul 3, 2021
View reviewed changes
@aboch
Copy link
Copy Markdown
Collaborator

aboch commented Sep 15, 2021

LGTM

But I we need to wait for @vishvananda to see if he can revive Travis CI integration

@aboch
Copy link
Copy Markdown
Collaborator

aboch commented Sep 16, 2021

Please rebase and force-push so that CI (now fixed) is triggered

@bersoare bersoare requested a review from aboch September 17, 2021 08:52
@aboch
Copy link
Copy Markdown
Collaborator

aboch commented Sep 17, 2021

LGTM

@aboch aboch merged commit 7992ad9 into vishvananda:master Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aboch aboch Awaiting requested review from aboch

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bersoare @aboch