Remove trailing null char from string in devlink#651
Merged
aboch merged 1 commit intovishvananda:masterfrom May 18, 2021
Merged
Remove trailing null char from string in devlink#651aboch merged 1 commit intovishvananda:masterfrom
aboch merged 1 commit intovishvananda:masterfrom
Conversation
netlink(kernel) returns the string values in a c-style manner terminating with null. when converting to go string these need to be removed as done in other places in the project. keeping the null terminating char prevents comparing devlink dev/port string attributes as the `==` string operand will fail. Signed-off-by: Adrian Chiris <adrianc@nvidia.com>
Collaborator
Author
paravmellanox
approved these changes
May 18, 2021
Contributor
paravmellanox
left a comment
There was a problem hiding this comment.
Reviewed-by: Parav Pandit parav@nvidia.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
netlink(kernel) returns the string values in a c-style
manner terminating with null.
when converting to go string these need to be removed
as done in other places in the project.
keeping the null terminating char prevents comparing
devlink dev/port string attributes as the
==stringoperand will fail.
Signed-off-by: Adrian Chiris adrianc@nvidia.com