netlink: xfrm, add optional field to XfrmPolicyTmpl#626
Merged
aboch merged 1 commit intovishvananda:masterfrom Mar 24, 2021
Merged
netlink: xfrm, add optional field to XfrmPolicyTmpl#626aboch merged 1 commit intovishvananda:masterfrom
aboch merged 1 commit intovishvananda:masterfrom
Conversation
Collaborator
|
is it possible to add or extend current UT to verify this information was passed down to kernel, for ex write it and read it back? |
Add optional field in XfrmPolicyTmpl to template code so users can
configure template optional values.
Tested via:
$ go test -exec sudo . -run XfrmPolicyWithOptional
ok github.com/vishvananda/netlink 0.009s
Co-authored-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Joe Stringer <joe@cilium.io>
Signed-off-by: John Fastabend <john.fastabend@gmail.com>
d826f2a to
49f192e
Compare
Contributor
Author
|
@aboch 👍 good call, the deserialization was missing. I've added a test and it passes: |
Contributor
Author
|
@aboch any update, does the new version look OK? |
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional field in XfrmPolicyTmpl to template code so users can
configure template optional values.