Merged
Conversation
Commit ec93726 ("Adds strings translation methods") broke non-Linux builds by relying on unix constants that are only declared on the linux platform in the upstream x/sys/unix package. Other platforms report undefined variables, such as the following: $ GOOS=darwin go build . # github.com/vishvananda/netlink ./route.go:17:7: undefined: SCOPE_UNIVERSE ./route.go:19:7: undefined: SCOPE_SITE ./route.go:21:7: undefined: SCOPE_LINK ./route.go:23:7: undefined: SCOPE_HOST ./route.go:25:7: undefined: SCOPE_NOWHERE ./route.go:55:7: undefined: unix.RTPROT_BABEL ./route.go:57:7: undefined: unix.RTPROT_BGP ./route.go:59:7: undefined: unix.RTPROT_BIRD ./route.go:61:7: undefined: unix.RTPROT_BOOT ./route.go:63:7: undefined: unix.RTPROT_DHCP ./route.go:63:7: too many errors Move the platform-specific implementations to platform-specific files and add stubs to satisfy other platforms. Fixes: ec93726 ("Adds strings translation methods") Signed-off-by: Joe Stringer <joe@cilium.io>
Contributor
|
Thank you @joestringer |
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit ec93726 ("Adds strings translation methods") broke non-Linux
builds by relying on unix constants that are only declared on the linux
platform in the upstream x/sys/unix package.
Other platforms report undefined variables, such as the following:
Move the platform-specific implementations to platform-specific files
and add stubs to satisfy other platforms.
Fixes: ec93726 ("Adds strings translation methods")
CC @riccardomanfrin @aboch