Make IPSet actually support IPs, and fix protocol errors for newer kernels#617
Merged
aboch merged 1 commit intovishvananda:masterfrom Mar 27, 2021
Merged
Conversation
95ef95d to
a73f3d3
Compare
yarinwinter
reviewed
Mar 8, 2021
Author
|
I'd be happy to address any comments you might have https://travis-ci.org/github/vishvananda/netlink/builds/761936947 |
b6ce930 to
d618bed
Compare
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #609
Added support for IPSets based on IP rather than just MAC address.
With the release of IPSet v7, the protocol response for
PROTOCOL_MINis now potentially more relevant, so theIpsetProtocol()function has been updated to return this too.I'd like to improve the protocol testing of all functions this area to ensure protocol parity with the userland ipset binary at some point (I built a debug version of http://git.netfilter.org/ipset/ using
-DIPSET_DEBUGand this patch:which prints out the serialised payloads being sent, but this package will need some refactoring to make the request generation independent of the request execution - I might put that into a separate PR