Skip to content

Adds String methods to several bond params and fixes Packers -> Packets#598

Merged
aboch merged 1 commit intovishvananda:masterfrom
riccardomanfrin:string_translations
Mar 4, 2021
Merged

Adds String methods to several bond params and fixes Packers -> Packets#598
aboch merged 1 commit intovishvananda:masterfrom
riccardomanfrin:string_translations

Conversation

@riccardomanfrin
Copy link
Copy Markdown
Contributor

No description provided.

@riccardomanfrin riccardomanfrin changed the title Adds String methods to several bond params Adds String methods to several bond params and fixes Packers -> Packets Nov 26, 2020
@aboch
Copy link
Copy Markdown
Collaborator

aboch commented Dec 28, 2020

@riccardomanfrin go1.13 and go1.14 CIs failed at

image

Please also squash you commits into one

@riccardomanfrin
Copy link
Copy Markdown
Contributor Author

riccardomanfrin commented Mar 4, 2021

I've squashed the commits and removed

case unix.RTPROT_KEEPALIVED:
    return "keepalived"

Let me know if it's oK Ciao

@aboch
Copy link
Copy Markdown
Collaborator

aboch commented Mar 4, 2021

You are proposing 2 commits. One that adds x number of things and one that remove something from x.

Please have only one commit.

If you are concerned about leaving a trace about why RT_PROT is not stringified, leave it in the code commented out, with explanation. So somebody can uncomment it in future when the current three go release used support that unix pkg field.

RTPROT_KEEPALIVED is commented to interop with earlier go versions (1.13, 1.14)
@aboch
Copy link
Copy Markdown
Collaborator

aboch commented Mar 4, 2021

Grazie @riccardomanfrin

LGTM

@aboch aboch merged commit ec93726 into vishvananda:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants