Skip to content

Allows direct usage of String() method#594

Merged
aboch merged 1 commit intovishvananda:masterfrom
riccardomanfrin:no_cast_usage_of_bond_consts
Nov 19, 2020
Merged

Allows direct usage of String() method#594
aboch merged 1 commit intovishvananda:masterfrom
riccardomanfrin:no_cast_usage_of_bond_consts

Conversation

@riccardomanfrin
Copy link
Copy Markdown
Contributor

No description provided.

@aboch
Copy link
Copy Markdown
Collaborator

aboch commented Nov 18, 2020

I am not able to correlate the commit title "Allows direct usage of String() method" to the actual changes.

@riccardomanfrin
Copy link
Copy Markdown
Contributor Author

riccardomanfrin commented Nov 19, 2020

I am not able to correlate the commit title "Allows direct usage of String() method" to the actual changes.

Sorry for not being explicit.

By changing

BondLinkUp = iota

into this

BondLinkUp BondSlaveMiiStatus = iota

you can call

BondLinkUp.String()

instead of

BondLinkUp.(BondSlaveMiiStatus).String()

The rest is abit of linting by vscode

@aboch
Copy link
Copy Markdown
Collaborator

aboch commented Nov 19, 2020

LGTM

@aboch aboch merged commit 8b65537 into vishvananda:master Nov 19, 2020
@riccardomanfrin riccardomanfrin deleted the no_cast_usage_of_bond_consts branch November 23, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants