Fixed endianity problem with Geneve tunnel VNI#582
Merged
aboch merged 1 commit intovishvananda:masterfrom Dec 6, 2020
Merged
Conversation
Author
|
Test failure is because the tests are running on ubuntu 16.04 where iproute2 doesn't support dstport for Geneve. So the options are:
|
Owner
|
can you try modifying the travis config in your branch to use a newer version of ubuntu? That way we can see if any other tests start failing. |
Author
|
Doesn't look good, we have problems with modprobe nf_conntrack_ipv4 and qdisc |
Author
|
Pull request was changes so we don't attempt to explicitly set the distort. It rely (and verify) the implicit Geneve port so we don't actually loose a lot in testing. |
aboch
reviewed
Nov 22, 2020
Collaborator
|
please rebase |
Author
|
Most of the support was done in a separate commit, but the endianity problem need to be fixed |
Collaborator
|
Thanks. |
2. Parse remote IP 3. Added unit test to test geneve paramters against "ip link"
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that VNI (ID in the code) is passed in host order.
The change include tests to verify that we use the correct endianity: It create a tunnel using
ip linkand read the ID of that tunnel proving that reading has the correct endianity. The test that set and read proves that the write endianity is the same as the read.