SocketDiagTCPInfo: Add support for BBR information#572
SocketDiagTCPInfo: Add support for BBR information#572aboch merged 1 commit intovishvananda:masterfrom taktv6:master
Conversation
|
Any chance I could get some feedback? |
|
This is looking good to me. Any way to add a test for the functionality? Also, when you are ready to go, please squash your changes down into a single commit. |
|
Thank you for your feedback. I've refactored the SocketDiagTCPInfo function and added some tests. |
|
This would be super useful to have - any news on this? |
|
@vishvananda feedback pls? |
|
LGTM Please squash these changes in one commit ("Squash and merge" is not enabled here). |
|
Okay. But any idea about the testify issue? |
Yes, I'd suggest to remove the testify import from these changes. Check the struct equality in the test code. I would stick to the builtin go testing package, because of the simplicity of the functions that needs to be tested here and for keeping this small library code base lean. |
|
Okay. I'll sort that out tomorrow. Thanks! |
|
LGTM |
No description provided.