Service curves fix#513
Merged
fcrisciani merged 1 commit intovishvananda:masterfrom Jan 27, 2020
fbegyn:fix-service-curve
Merged
Service curves fix#513fcrisciani merged 1 commit intovishvananda:masterfrom fbegyn:fix-service-curve
fcrisciani merged 1 commit intovishvananda:masterfrom
fbegyn:fix-service-curve
Conversation
There was something off with the math for the ServiceCurves. The set value was 8 times too large and the returned one was 8 times too small. This is now fixed in `class.go` and `class_linux.go` so the user can just set the rate in bit and it will match the tc show output.
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was something off with the math for the ServiceCurves. The set value was 8 times too large and the returned one was 8 times too small. This is now fixed in
class.goandclass_linux.goso the user can just set the rate in bit and it will match the tc show output.In light of this change I've also expanded the comments of the functions to offer more information as to how these work. Before the function gave the misleading impression that they behaved exactly like the
tccommand-line tool, which was not the case. This commit fixes this and correct the behaviour as intended.