Skip to content

xfrm: don't send SA_PCPU during get/delete#1172

Merged
aboch merged 1 commit intovishvananda:mainfrom
ti-mo:tb/xfrm-sa-cpu-new-del
Mar 10, 2026
Merged

xfrm: don't send SA_PCPU during get/delete#1172
aboch merged 1 commit intovishvananda:mainfrom
ti-mo:tb/xfrm-sa-cpu-new-del

Conversation

@ti-mo
Copy link
Copy Markdown
Contributor

@ti-mo ti-mo commented Mar 10, 2026 •
edited by coderabbitai bot
Loading

Since Linux v6.13 or 83dfce38c49f ("xfrm: Restrict percpu SA attribute to specific netlink message types") SA_PCPU is only allowed in MSG_NEWSA, UPDSA, ALLOCSPI, ACQUIRE. For all other commands, it needs to be unset.

Also fix accessing *sa.Pcpunum in XfrmState.String() that would panic when the field is nil.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the display format of per-CPU state numbers in debug output with proper nil handling.
    • Removed incorrect attribute emission when reading or deleting IPSec states.

@ti-mo
xfrm: don't send SA_PCPU during get/delete
b90d8de 
Since Linux v6.13 or 83dfce38c49f ("xfrm: Restrict percpu SA attribute to
specific netlink message types") SA_PCPU is only allowed in MSG_NEWSA, UPDSA,
ALLOCSPI, ACQUIRE. For all other commands, it needs to be unset.

Also fix accessing *sa.Pcpunum in XfrmState.String() that would panic when the
field is nil.

Signed-off-by: Timo Beckers <timo@incline.eu>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 10, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4fbf6a12-d5e1-4ed1-9bc3-76a2c6d37182

📥 Commits

Reviewing files that changed from the base of the PR and between d450941 and b90d8de.

📒 Files selected for processing (1)
  • xfrm_state_linux.go
📝 Walkthrough

Walkthrough

Changes to XfrmState.String() method to print Pcpunum as a string with nil handling. Removal of PCPU attribute emission in xfrmStateGetOrDelete when reading or deleting state.

Changes

Cohort / File(s) Summary
XfrmState String and PCPU Handling
xfrm_state_linux.go		 Modified XfrmState.String() to display Pcpunum as string with nil handling; removed XFRMA_SA_PCPU attribute emission in xfrmStateGetOrDelete function.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A hop through the state, a fix so fine,
Pcpunum now speaks in strings divine,
No PCPU whispers when deleting with care,
Attributes pruned with a developer's flair! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: preventing SA_PCPU attribute from being sent during get/delete operations, which is the primary behavioral change in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ti-mo ti-mo mentioned this pull request Mar 10, 2026
Merged
bersoare
bersoare approved these changes Mar 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@bersoare bersoare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@aboch
Copy link
Copy Markdown
Collaborator

aboch commented Mar 10, 2026

Thank you @ti-mo !

LGTM

@aboch aboch merged commit 0fc8972 into vishvananda:main Mar 10, 2026
3 checks passed
@ti-mo ti-mo deleted the tb/xfrm-sa-cpu-new-del branch March 10, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bersoare bersoare bersoare approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-mo @aboch @bersoare