Add IFLA_PARENT_DEV_NAME / IFLA_PARENT_DEV_BUS_NAME to links#1051
Merged
aboch merged 1 commit intovishvananda:mainfrom Jan 28, 2025
Merged
Add IFLA_PARENT_DEV_NAME / IFLA_PARENT_DEV_BUS_NAME to links#1051aboch merged 1 commit intovishvananda:mainfrom
aboch merged 1 commit intovishvananda:mainfrom
Conversation
Contributor
Author
|
It seems the failing test is a flake. I was able to reproduce it once out of a few runs on |
These attributes are supported since kernel v5.14 (see [1]). Here's
what iproute2 shows:
```
$ ip -d link show eth0
4: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 65535 qdisc pfifo_fast state UP mode DEFAULT group default qlen 1000
... parentbus virtio parentdev virtio0
```
[1]: torvalds/linux@00e77ed
Signed-off-by: Albin Kerouanton <albinker@gmail.com>
fca5ade to
bc9fc1d
Compare
Collaborator
|
Thanks @akerouanton |
Contributor
Author
|
@aboch Testing this one is quite challenging because you need a physical interface to have a 'parent' reported, and there's no way to guarantee that the same parent will be available across CI, developers' machine, etc… or even if there'll be at least one interface with a 'parent'. I'd need to mock the netlink response to test that, but it seems no other tests are using mocks. |
Collaborator
|
LGTM |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These attributes are supported since kernel v5.14 (see 1). Here's what iproute2 shows: