Skip to content

tests: Improve address unit test infrastructure#1047

Merged
adrianchiris merged 1 commit intovishvananda:mainfrom
yunginnanet:fix-test-addr
Apr 3, 2025
Merged

tests: Improve address unit test infrastructure#1047
adrianchiris merged 1 commit intovishvananda:mainfrom
yunginnanet:fix-test-addr

Conversation

@yunginnanet
Copy link
Copy Markdown
Contributor

Summary

This pull request refactors the addr_test.go file and does not touch any non-test functionality.

Changes

  • Structural Refactoring: Transition to the addrTest struct for organizing test parameters.
  • Error Handling Improvements: Centralize and simplify error handling using helper functions within the test struct. Add canFail to make some tests optional.
  • Differentiate Tests: Add test case names to separate out the test cases during troubleshooting.
  • Misc: Minor grammar fix.

@adrianchiris
Copy link
Copy Markdown
Collaborator

@yunginnanet please squash to a single commit and we can merge this one.

Signed-off-by: kayos@tcp.direct <kayos@tcp.direct>
@adrianchiris adrianchiris merged commit 38b1229 into vishvananda:main Apr 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants