fix CI failed Incidental in TestRuleListFiltered#1043
Merged
aboch merged 1 commit intovishvananda:mainfrom Dec 27, 2024
Merged
Conversation
Contributor
Author
|
@aboch, hi，thanks for reminding me to open a new PR, and this is UT fix for intermittent failures. Would you please take a look? |
cf9af49 to
add8126
Compare
Collaborator
|
LGTM |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I see many people failed check in TestRuleListFiltered, like #1042, and I've identified the issue causing intermittent failures in the CI，when rule add slow, check would failed.