Mimic ipset C code for determining correct default ipset revision for hash:ip{port,net,etc}#1031
Merged
aboch merged 1 commit intovishvananda:mainfrom May 9, 2025
Conversation
437fb9b to
d1562a9
Compare
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
d1562a9 to
bf21466
Compare
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1030
It takes both desired features AND set type into account when determining the "correct" default revision, which is how it actually works in the
ipsetuserspace binary.e.g.
hash:ip,port,netcommentsupport? Revision 5.countersupport? Revision 4.etc etc.
A more exhaustive mapping would be ideal, but this PR only does default revision mappings for the ipset types that previously had revision defaulting logic, and not all possible ipset types globally.