Conversation
|
great initiative, This should ideally come with a github workflow which will ensure the project remains gofumpted. |
Yes, it would be good to set up a linter in this repo; I see #859 gave this a try, but was closed. I just ran At least this PR should set a baseline for formatting, and we can do some periodic updates to fix regressions in that area (until a linter is in place). I rebased this PR, and should be ready for review again. 🙏 |
|
LGTM |
☝️ short update on that effort; I also opened a PR to fix most (not all) linting issues with the default golangci-lint settings; #1048. There are still some linting issues to address after that one that may need some eyes (either fix or suppress), after which I can add a golangci-lint action to this repository. |
701f927 to
fe4839d
Compare
|
@aboch PTAL 🙏 (this one helps a lot with people having their editor configured to |
|
@aboch PTAL 🙏 |
|
Rebased; @aboch @vishvananda PTAL |
|
Rebased 👍 |
|
@thaJeztah sorry, can you rebase again :) |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
Sure, no problem; done 👍 |
|
@thaJeztah bumping to get some fumpting 😃 |
No description provided.