refactor: refactor underlying architecture and greatly simplified the framework #60
Conversation
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
|
||
| except Exception as e: | ||
| log.error(f"Error executing new command: {e}") | ||
| return |
There was a problem hiding this comment.
Bug: Duplicate asset directory creation on success.
In NewCommand.execute, the asset directory is created twice when validation succeeds. The code on lines 72-73 duplicates the asset directory creation logic already present on lines 66-67, leading to redundant operations.
| Returns: | ||
| MkdocsNoteConfig: The plugin configuration | ||
| """ | ||
| return plugin.config |
There was a problem hiding this comment.
Bug: Static attribute access causes runtime AttributeError
The get_plugin_config function tries to access plugin.config. Since plugin refers to the MkdocsNotePlugin class rather than an instance, and config is an instance attribute, this will result in an AttributeError at runtime.
Note
Major v3 refactor introducing a new CLI, simplified configuration, streamlined plugin with recent-notes and network graph, and extensive doc/test updates while removing legacy code.
utils.scanner,utils.meta, and revampedgraphutilities; remove old assets/docs handlers and custom logger.MkdocsNoteConfigwithnotes_root,recent_notes_config,graph_config.mkdocs-notewith commands:new,remove/rm,move/mv,clean; shared utils inutils/cli/commandsandutils/cli/common.<!-- recent_notes -->marker.graph.jsongeneration post-build.graph_config; deprecate/unpublish older pages.mkdocs.ymlto new config schema;pyproject.tomlversion bump to3.0.0.pytest; add extensive tests for CLI, config, plugin; remove obsolete tests.justfiletest command; removevercel.json; refresh lockfile.Written by Cursor Bugbot for commit 3d46ed8. This will update automatically on new commits. Configure here.