agent: Add invalid peer enodes to disconnect log message#85
Merged
Conversation
ryanschneider
approved these changes
Nov 15, 2019
Collaborator
ryanschneider
left a comment
There was a problem hiding this comment.
lgtm, only thing I could think that might be helpful is the list of ActivePeers, but I think that makes the log message way to long and spammy, so maybe a later feature would be to add dynamic verbosity, possibly using the debug.vmodule RPC implementation from geth or something similar.
Member
Author
|
@ryanschneider I've been thinking of exposing local/private-only RPCs, or maybe a /health endpoint for agents that could include this info. What do you think? |
Member
Author
|
Opened #86 for brainstorming the health endpoint. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding some better logging to help debug in the future.
@ryanschneider Can you think of anything else that would help in this scenario?