Change injection technique to use src with Blob #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would this work on Firefox 57? |
Member
|
That's great! Could you fix the lint errors? Maybe we should add |
18f5c60 to
796cddd
Compare
Contributor
Author
|
@gera2ld Fixed. We should definitely use revokeObjectURL to prevent leaks. |
Member
|
This has brought up a new problem, which breaks VM web page listeners on Chrome stable Win 10. But works on Chrome any Mac OS X, and Chrome canary Win 10. I think it's a bug of Chrome on Windows but should be fixed by a workaround now. See #249 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #173. And makes Violentmonkey work on recent builds of Firefox 58 on pages with CSP.