ci: bump rustc to 1.60 for fuzz test#2
Merged
vincenzopalazzo merged 4 commits intomasterfrom Oct 10, 2023
Merged
Conversation
cf313ae to
8b03531
Compare
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Clippy warns: redundant guard As suggested, remove the redundant guard.
8b03531 to
05d3dc5
Compare
error[E0308]: mismatched types
--> bitcoin/src/psbt/raw.rs:87:24
|
87 | return Err(encode::Error::OversizedVectorAllocation {
| ________________________^
88 | | requested: key_byte_size as usize,
89 | | max: MAX_VEC_SIZE,
90 | | });
| |_____________^ expected enum `psbt::error::Error`, found enum `consensus::encode::Error`
|
help: try wrapping the expression in `psbt::error::Error::ConsensusEncoding`
|
87 ~ return Err(psbt::error::Error::ConsensusEncoding(encode::Error::OversizedVectorAllocation {
88 | requested: key_byte_size as usize,
89 | max: MAX_VEC_SIZE,
90 ~ }));
|
----
Compiling bitcoin v0.30.0 (/home/vincent/github/work/rust-btc/rust-bitcoin/bitcoin)
Checking bitcoin-fuzz v0.0.1 (/home/vincent/github/work/rust-btc/rust-bitcoin/fuzz)
error: redundant clone
--> bitcoin/examples/taproot-psbt.rs:453:77
|
453 | witness_utxo: { Some(TxOut { value, script_pubkey: script_pubkey.clone() }) },
| ^^^^^^^^ help: remove this
|
= note: `-D clippy::redundant-clone` implied by `-D warnings`
note: this value is dropped without further use
--> bitcoin/examples/taproot-psbt.rs:453:64
|
453 | witness_utxo: { Some(TxOut { value, script_pubkey: script_pubkey.clone() }) },
| ^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
error: could not compile `bitcoin` due to previous error
warning: build failed, waiting for other jobs to finish...
error: redundant clone
--> bitcoin/src/psbt/mod.rs:1095:13
|
1095 | .clone()
| ^^^^^^^^ help: remove this
|
= note: `-D clippy::redundant-clone` implied by `-D warnings`
note: this value is dropped without further use
--> bitcoin/src/psbt/mod.rs:1094:17
|
1094 | assert!(psbt
| _________________^
1095 | | .clone()
| |____________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.