Fix JSON namespace/class ambiguity#65
Merged
caseypugh merged 3 commits intovimeo:masterfrom Jan 2, 2019
Merged
Conversation
… Matt Shoen,s: don't use the overloaded JSON symbol, and use a more explicit JSONNode class reference JSONNode node = JSONNode.Parse(jsonString); makes more sense than: JSONNode node = JSON.Parse(jsonString);
caseypugh
approved these changes
Jan 2, 2019
Contributor
caseypugh
left a comment
There was a problem hiding this comment.
This looks great, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A suggested fix for issue #51 , to remove ambiguity conflict with a JSON library like Matt Shoen's: don't use the overloaded JSON symbol, and instead use directly the JSONNode class:
JSONNode node = JSONNode.Parse(jsonString);
feels better than:
JSONNode node = JSON.Parse(jsonString);