Skip to content

Fixes #9827 (in a different way)#9909

Closed
ygottschalk wants to merge 3 commits intovimeo:masterfrom
ygottschalk:fix/9827-union-empty-array-and-false-2
Closed

Fixes #9827 (in a different way)#9909
ygottschalk wants to merge 3 commits intovimeo:masterfrom
ygottschalk:fix/9827-union-empty-array-and-false-2

Conversation

@ygottschalk
Copy link
Copy Markdown
Contributor

See #9903 for discussion
Fixes #9827 (in a different way than #9903)

@ygottschalk ygottschalk mentioned this pull request Jun 13, 2023
@ygottschalk ygottschalk force-pushed the fix/9827-union-empty-array-and-false-2 branch from 93b251f to a05b7bc Compare June 13, 2023 08:57
@ygottschalk
Copy link
Copy Markdown
Contributor Author

ygottschalk commented Jun 13, 2023

Build error seems to come from here: https://github.com/vimeo/psalm/pull/9909/files#diff-4f029c4356416f8c892d88d24cc3e7a2d389e74a3fadc739ad0970ffedae233dR153-R160
bcs the if (L130) branch of the if/elseif is not entered with the new logic, the elseif branch is.

Can invest more time on the issue if this is the version we want to go with (see linked PR). Awaiting feedback

@orklah orklah closed this Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Union of empty-array and false is false

2 participants