Recursively resolve template parameters#9667
Closed
boesing wants to merge 2 commits intovimeo:masterfrom
Closed
Conversation
boesing
commented
Apr 18, 2023
| } | ||
|
|
||
| /** | ||
| * @param non-empty-array<Atomic> $types |
Contributor
Author
There was a problem hiding this comment.
I've tried to add @psalm-assert-if-true so that we can provide non-empty-array<TKeyedArray> to get rid of the inline @var annotations above but that sadly didn't work but I dont have time to improve this for now.
boesing
commented
Apr 18, 2023
| } | ||
|
|
||
| if ($keyed_intersection_types === []) { | ||
| return ['object' => new TObjectWithProperties([], [], [], $object_from_docblock)]; |
Contributor
Author
There was a problem hiding this comment.
- Seems that this actually leads to the issuebuffer test issue.
will see how to improve that later this week
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
064c890 to
bdb8baf
Compare
boesing
commented
Jun 22, 2023
7961a11 to
6831f4f
Compare
6831f4f to
6d23727
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4193