Skip to content

Issue 9433#9436

Closed
ptomulik wants to merge 0 commit intovimeo:masterfrom
ptomulik:issue-9433
Closed

Issue 9433#9436
ptomulik wants to merge 0 commit intovimeo:masterfrom
ptomulik:issue-9433

Conversation

@ptomulik
Copy link
Copy Markdown
Contributor

@ptomulik ptomulik commented Mar 1, 2023

An attempt to fix #9433. Some errors appeared, reported by "Run Shepherd" action. Need a little guidance to fix this, but it looks like the immediate effect of bug fixing (i.e. the code seemed to work thanks to false-negative behavior, that has just been fixed here).

@weirdan
Copy link
Copy Markdown
Collaborator

weirdan commented Mar 1, 2023

Some errors appeared, reported by "Run Shepherd"

ImpureFunctionCall errors are from another problematic (now reverted) PR. Please rebase.

@ptomulik
Copy link
Copy Markdown
Contributor Author

ptomulik commented Mar 1, 2023

I've just messed things up (force pushed master as to this branch and lost my changes)... gosh. One stupid mistake at the morning ;)

@weirdan
Copy link
Copy Markdown
Collaborator

weirdan commented Mar 1, 2023

image

You can reset the branch to the way it was before your force-push: git reset --hard f078382

@ptomulik
Copy link
Copy Markdown
Contributor Author

ptomulik commented Mar 1, 2023

The changes were small, so I just managed to reproduce them manually.

@ptomulik ptomulik mentioned this pull request Mar 1, 2023
@ptomulik
Copy link
Copy Markdown
Contributor Author

ptomulik commented Mar 2, 2023

Opened new PR #9439 to continue work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IfAnalyzer incorrectly updates outer scope

2 participants