Properly propagate clones#8131
Closed
danog wants to merge 3 commits intovimeo:masterfrom
Closed
Conversation
Collaborator
|
Seems good :) Could you try running a before/after to see the impact on memory usage? |
Contributor
|
@danog you just need to run psalm on any project of your choice once with and once without your changes; the output contains a line like this at the end:
If you could post it here for before/after we could get this merged. |
Collaborator
Author
|
I actually started working on the immutability PRs that should supersede this one, I should actually close this :) |
Contributor
|
But since this is done, we could at least merge this and have some of the benefits now, while you're still working on the other PR? |
Collaborator
|
This will go on master and I'm waiting for the immutable PR to release the master branch so it won't come quicker anyway |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes more storage corruption issues I've detected by making stored Unions immutable.