[Feat]: Initial Support for LSP Code Actions#7255
Merged
weirdan merged 5 commits intovimeo:masterfrom Jan 2, 2022
Merged
Conversation
Contributor
Author
|
@joehoyle thoughts? As you've worked on the LSP in the past as well |
Collaborator
|
Thanks! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds initial support for Code Actions in the Language Server.
Code actions allow a user in their respective IDE to right click an error and implement a "quickfix".
The initial work only implements the ability to suppress errors. The reasoning for this is because it seems difficult in Psalms current state to query the diff from Psalter while running in the Language server (More investigation needs to be done here.
Here's an example of this working in VSCode using: https://github.com/psalm/psalm-vscode-plugin
Screen.Recording.2021-12-30.at.3.16.45.PM.mov
The next steps after this would be to enable the ability to auto fix issues from Psalter.