Fix not always positive bit operations#5233
Merged
muglug merged 3 commits intovimeo:masterfrom Feb 16, 2021
orklah:bits-operations-are-weird
Merged
Fix not always positive bit operations#5233muglug merged 3 commits intovimeo:masterfrom orklah:bits-operations-are-weird
muglug merged 3 commits intovimeo:masterfrom
orklah:bits-operations-are-weird
Conversation
|
I found these snippets: https://psalm.dev/r/2ba369ca91<?php
$a = 1;
$b = 1;
$c = 32;
$d = 64;
if (0 === ($a ^ $b)) {
echo "Actually, zero\n";
}
if (0 === ($a >> $b)) {
echo "Actually, zero\n";
}
if (8 === PHP_INT_SIZE) {
if (0 === ($a << $d)) {
echo "Actually, zero\n";
}
} else {
if (0 === ($a << $c)) {
echo "Actually, zero\n";
}
} |
Contributor
|
I think you missed |
Collaborator
Author
|
Thanks! Added! |
Collaborator
|
Thanks! |
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #5227
I'll wait to see failing tests to see if I just fix them or if I add this example: https://psalm.dev/r/2ba369ca91