Skip to content

Introduce Virtual Nodes in order to differentiate real nodes in plugins#5222

Merged
muglug merged 1 commit intovimeo:masterfrom
orklah:virtualnodes
Feb 15, 2021
Merged

Introduce Virtual Nodes in order to differentiate real nodes in plugins#5222
muglug merged 1 commit intovimeo:masterfrom
orklah:virtualnodes

Conversation

@orklah
Copy link
Copy Markdown
Collaborator

@orklah orklah commented Feb 14, 2021

This should solve #5215

A few notes:

  1. I had errors in PhpParser pop up now that Psalm's code inherits PhpParser code and Psalm's PropertyMap being more precise than PhpParser's code
  2. I had errors in Psalm for Unused classes because I migrated every Node from PhpParser, not only used Nodes. Not sure if I should keep it or delete those.

@muglug
Copy link
Copy Markdown
Collaborator

muglug commented Feb 15, 2021

Sorry, mind merging again? I did a dumb thing

@orklah
Copy link
Copy Markdown
Collaborator Author

orklah commented Feb 15, 2021

Done.

I notice there are errors in Code Style because it doesn't like the _ at the end for classes that are also keywords. Not sure what should be done about that

@muglug
Copy link
Copy Markdown
Collaborator

muglug commented Feb 15, 2021

Not sure what should be done about that

Just remove the underscore. The only reason the underscore exists in PhpParser is because Class is a reserved word. When extending and renaming there's no need to keep that convention.

@orklah
Copy link
Copy Markdown
Collaborator Author

orklah commented Feb 15, 2021

Done :)

@muglug muglug merged commit 5191dac into vimeo:master Feb 15, 2021
@muglug
Copy link
Copy Markdown
Collaborator

muglug commented Feb 15, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants