Skip to content

Rename stub to avoid phpstorm conflict#5213

Merged
muglug merged 1 commit intovimeo:masterfrom
VincentLanglet:stub
Feb 13, 2021
Merged

Rename stub to avoid phpstorm conflict#5213
muglug merged 1 commit intovimeo:masterfrom
VincentLanglet:stub

Conversation

@VincentLanglet
Copy link
Copy Markdown
Contributor

Hi @muglug

Phpstorm is higlighting my Exception because I'm providing a string to the constructor.
I discovered it's because there is an Exception class in the MissingMethod stub.

To avoid such issue, all the stubs should used the .phpstub extension IMHO.

@muglug
Copy link
Copy Markdown
Collaborator

muglug commented Feb 13, 2021

Thanks – please update the references in PHP too!

@VincentLanglet VincentLanglet force-pushed the stub branch 2 times, most recently from 4b6eb0a to f423ac5 Compare February 13, 2021 21:57
@VincentLanglet
Copy link
Copy Markdown
Contributor Author

Fixed @muglug :)

@muglug muglug merged commit a80d5b7 into vimeo:master Feb 13, 2021
@muglug
Copy link
Copy Markdown
Collaborator

muglug commented Feb 13, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants