Regenerate callmap, add \Roundable parameter possibility to round PHP8.4#11326
Closed
Regenerate callmap, add \Roundable parameter possibility to round PHP8.4#11326
Conversation
danog
reviewed
Feb 20, 2025
| 'removed' => | ||
| array ( | ||
| ), | ||
| ); No newline at end of file |
Collaborator
There was a problem hiding this comment.
You should have added the new signature in here as well as in CallMap.php.
Author
There was a problem hiding this comment.
I don't really understand, because the override delta has this signature?
'round' =>
array (
'old' =>
array (
0 => 'float',
'num' => 'float|int',
'precision=' => 'int',
'mode=' => 'int<0, max>',
),
'new' =>
array (
0 => 'float',
'num' => 'float|int',
'precision=' => 'int',
'mode=' => 'RoundingMode|int<0, max>',
),
),
Author
There was a problem hiding this comment.
I don't think i need to commit something else right? :)
It should be all there, however Github doesn't really allow us to check it online.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for adding Roundable to the round- function as a possible parameter.
I also had to change the gen_callmap.sh to generate a new callmap.
After generation, more files did change, the changes to the round-function did pick up.