I found these snippets:

https://psalm.dev/r/7a0b9aed9f

<?php

interface EntityInterface
{
    public function getId(): string;
}

/**
 * @phpstan-template T of EntityInterface
 */
interface RepositoryInterface
{
    /**
     * @return T|null
     */
   public function byId(string $id);
}

final class Foo implements EntityInterface
{
    public function getId(): string
    {
        return '42';
    }
}

/**
 * @phpstan-implements RepositoryInterface<Foo>
 */
final class FooRepository implements RepositoryInterface
{
    /**
     * @var Foo[]
     */
    public array $elements = [];

    public function byId(string $id): ?Foo
    {
        return $this->elements[$id] ?? null;
    }
}

Psalm output (using commit 7d95f15):

ERROR: InvalidReturnStatement - 39:16 - The inferred type 'Foo|null' does not match the declared return type 'null' for FooRepository::byId

ERROR: InvalidReturnType - 37:39 - The declared return type 'null' for FooRepository::byId is incorrect, got 'Foo|null'

https://psalm.dev/r/0641fa1047

<?php

interface EntityInterface
{
    public function getId(): string;
}

/**
 * @phpstan-template T of EntityInterface
 */
interface RepositoryInterface
{
    /**
     * @return T|null
     */
   public function byId(string $id);
}

class Foo implements EntityInterface
{
    public function getId(): string
    {
        return '42';
    }
}

/**
 * @phpstan-implements RepositoryInterface<Foo>
 */
final class FooRepository implements RepositoryInterface
{
    /**
     * @var Foo[]
     */
    public array $elements = [];

    public function byId(string $id): ?Foo
    {
        return $this->elements[$id] ?? null;
    }
}

Psalm output (using commit 7d95f15):

No issues!

Psalm 5: InvalidReturnType regression for final classes #8925

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions