Fix JSON reports with long UTF8 strings#5300
Merged
muglug merged 3 commits intovimeo:masterfrom Mar 1, 2021
Merged
Conversation
weirdan
reviewed
Mar 1, 2021
Collaborator
|
Thanks! |
This was referenced Mar 15, 2021
Closed
This was referenced Mar 17, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When printing keyed arrays or literal strings containing more than 80 characters, the old logic may cut off a UTF8 codepoint in half, causing an error when encoding JSON reports.
Also added a call to json_last_error_msg to obtain a detailed error description.