Skip to content

Fix gd CallMap for PHP 8#5271

Merged
muglug merged 1 commit intovimeo:masterfrom
iluuu1994:gd-php8
Mar 1, 2021
Merged

Fix gd CallMap for PHP 8#5271
muglug merged 1 commit intovimeo:masterfrom
iluuu1994:gd-php8

Conversation

@iluuu1994
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Collaborator

@weirdan weirdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs corresponding changes to callmap delta.

@iluuu1994
Copy link
Copy Markdown
Contributor Author

The parameter names for PHP 7.4 might not match. Not sure if that matters.

@weirdan
Copy link
Copy Markdown
Collaborator

weirdan commented Feb 23, 2021

The parameter names for PHP 7.4 might not match. Not sure if that matters.

I believe it shouldn't.

@iluuu1994
Copy link
Copy Markdown
Contributor Author

Anything holding this up?

@muglug muglug merged commit 27e7fb5 into vimeo:master Mar 1, 2021
@muglug
Copy link
Copy Markdown
Collaborator

muglug commented Mar 1, 2021

Nope, thanks!

This was referenced Mar 15, 2021
This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants