Skip to content

Sprintf with only one argument without formatting directives leads to false TooFewArguments #10021

New issue
New issue
Closed
#10088
Closed
Sprintf with only one argument without formatting directives leads to false TooFewArguments#10021
#10088
@tscni

Description

@tscni
tscni
opened on Jul 15, 2023

https://psalm.dev/r/6c9dd0f8b3

Presumably caused by

psalm/src/Psalm/Internal/Provider/ReturnTypeProvider/SprintfReturnTypeProvider.php

Lines 73 to 86 in 564c6de

// it makes no sense to use sprintf when there is only 1 arg (the format)
// as it wouldn't have any placeholders
if (count($call_args) === 1 && $event->getFunctionId() === 'sprintf') {
IssueBuffer::maybeAdd(
new TooFewArguments(
'Too few arguments for ' . $event->getFunctionId() . ', expecting at least 2 arguments',
$event->getCodeLocation(),
$event->getFunctionId(),
),
$statements_source->getSuppressedIssues(),
);
return null;
}

It states

it makes no sense to use sprintf when there is only 1 arg (the format)
as it wouldn't have any placeholders

Which sure, is true, but that's a code style issue and not statically incorrect code.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions