Fix documentation around identity needing to be a string#558
Merged
Conversation
Previously we allowed identity to be any data that was JSON serializable, however it turns out that is in violation of the JWT spec, which requires `sub` to be a string. The underlying library that we are using to manage the JWTs (PyJWT) released a new version that is enforcing this behavior, where it didn't before. Because `sub` should be a string per the spec, I've opted to keep that change in this extension, and update the documentation to match this new behavior.
e422873 to
6957355
Compare
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we allowed identity to be any data that was JSON
serializable, however it turns out that is in violation of the JWT spec,
which requires
subto be a string. The underlying library that we areusing to manage the JWTs (PyJWT) released a new version that is
enforcing this behavior, where it didn't before.
Because
subshould be a string per the spec, I've opted to keep thatchange in this extension, and update the documentation to match this new
behavior.